yonote/yjs
23
0
Fork 0
Code Pull Requests 1 Releases Activity

fix #474 - formatting bug

Browse Source
This commit is contained in:
Kevin Jahns 2023-02-14 16:16:14 +01:00
parent e9189365ee
commit 1c999b250e
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/types/YText.js
View File

@ -382,12 +382,17 @@ const cleanupFormattingGap = (transaction, start, curr, startAttributes, currAtt
switch (content.constructor) { switch (content.constructor) {
case ContentFormat: { case ContentFormat: {
const { key, value } = /** @type {ContentFormat} */ (content) const { key, value } = /** @type {ContentFormat} */ (content)
if ((endAttributes.get(key) || null) !== value || (startAttributes.get(key) || null) === value) { const startAttrValue = startAttributes.get(key) || null
if ((endAttributes.get(key) || null) !== value || startAttrValue === value) {
// Either this format is overwritten or it is not necessary because the attribute already existed. // Either this format is overwritten or it is not necessary because the attribute already existed.
start.delete(transaction) start.delete(transaction)
cleanups++ cleanups++
if (!reachedEndOfCurr && (currAttributes.get(key) || null) === value && (startAttributes.get(key) || null) !== value) { if (!reachedEndOfCurr && (currAttributes.get(key) || null) === value && (startAttributes.get(key) || null) !== value) {
currAttributes.delete(key) if (startAttrValue === null) {
currAttributes.delete(key)
} else {
currAttributes.set(key, startAttrValue)
}
} }
} }
break break

2
tests/y-text.tests.js
View File

@ -206,7 +206,6 @@ export const testDeltaBug = _tc => {
} }
] ]
ytext.applyDelta(addingSpace) ytext.applyDelta(addingSpace)
debugger
const addingList = [ const addingList = [
{ {
retain: 12 retain: 12
@ -411,7 +410,6 @@ export const testDeltaBug = _tc => {
} }
] ]
t.compare(result, expectedResult) t.compare(result, expectedResult)
debugger
} }
/** /**