yonote/yjs
14
0
Fork 0
Code Pull Requests 1 Releases Activity

splitting an item must always happen inside a transaction, because we always need to check if we can merge it back

Browse Source
This commit is contained in:
Kevin Jahns
2019-04-11 00:23:08 +02:00
parent 9fe47e98d5
commit 2ef11a5344
18 changed files with 72 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/structs/ItemBinary.js
View File

@@ -7,7 +7,7 @@ import {
AbstractItemRef,
computeItemParams,
GC,
StructStore, Y, AbstractType, ID, YEvent // eslint-disable-line
StructStore, Transaction, AbstractType, ID // eslint-disable-line
} from '../internals.js'
import * as encoding from 'lib0/encoding.js'
@@ -69,13 +69,13 @@ export class ItemBinaryRef extends AbstractItemRef {
this.content = decoding.readPayload(decoder)
}
/**
* @param {Y} y
* @param {Transaction} transaction
* @param {StructStore} store
* @param {number} offset
* @return {ItemBinary|GC}
*/
toStruct (y, store, offset) {
const { left, right, parent, parentSub } = computeItemParams(y, store, this.left, this.right, this.parent, this.parentSub, this.parentYKey)
toStruct (transaction, store, offset) {
const { left, right, parent, parentSub } = computeItemParams(transaction, store, this.left, this.right, this.parent, this.parentSub, this.parentYKey)
return parent === null
? new GC(this.id, this.length)
: new ItemBinary(