yonote/yjs
23
0
Fork 0
Code Pull Requests 1 Releases Activity

dombinding: always set browser range after change

Browse Source
This commit is contained in:
Kevin Jahns 2018-07-16 18:15:24 +02:00
parent 860e4d7af6
commit 4022374620
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/Bindings/DomBinding/DomBinding.js
View File

@ -140,7 +140,6 @@ export default class DomBinding extends Binding {
restoreSelection (selection) { restoreSelection (selection) {
if (selection !== null) { if (selection !== null) {
const { to, from } = selection const { to, from } = selection
let shouldUpdate = false
/** /**
* There is little information on the difference between anchor/focus and base/extent. * There is little information on the difference between anchor/focus and base/extent.
* MDN doesn't even mention base/extent anymore.. though you still have to call * MDN doesn't even mention base/extent anymore.. though you still have to call
@ -159,7 +158,6 @@ export default class DomBinding extends Binding {
if (node !== baseNode || offset !== baseOffset) { if (node !== baseNode || offset !== baseOffset) {
baseNode = node baseNode = node
baseOffset = offset baseOffset = offset
shouldUpdate = true
} }
} }
} }
@ -171,18 +169,15 @@ export default class DomBinding extends Binding {
if (node !== extentNode || offset !== extentOffset) { if (node !== extentNode || offset !== extentOffset) {
extentNode = node extentNode = node
extentOffset = offset extentOffset = offset
shouldUpdate = true
} }
} }
} }
if (shouldUpdate) { browserSelection.setBaseAndExtent(
browserSelection.setBaseAndExtent( baseNode,
baseNode, baseOffset,
baseOffset, extentNode,
extentNode, extentOffset
extentOffset )
)
}
} }
} }