yonote/yjs
23
0
Fork 0
Code Pull Requests 1 Releases Activity

minimize changes when formatting text - #422

Browse Source
This commit is contained in:
Kevin Jahns 2022-05-09 12:53:26 +02:00
parent 40196ae0a3
commit ece1fe5426
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/types/YText.js
View File

@ -292,7 +292,16 @@ const formatText = (transaction, parent, currPos, length, attributes) => {
// iterate until first non-format or null is found // iterate until first non-format or null is found
// delete all formats with attributes[format.key] != null // delete all formats with attributes[format.key] != null
// also check the attributes after the first non-format as we do not want to insert redundant negated attributes there // also check the attributes after the first non-format as we do not want to insert redundant negated attributes there
while (currPos.right !== null && (length > 0 || currPos.right.content.constructor === ContentFormat)) { // eslint-disable-next-line no-labels
iterationLoop: while (
currPos.right !== null &&
(length > 0 ||
(
negatedAttributes.size > 0 &&
(currPos.right.deleted || currPos.right.content.constructor === ContentFormat)
)
)
) {
if (!currPos.right.deleted) { if (!currPos.right.deleted) {
switch (currPos.right.content.constructor) { switch (currPos.right.content.constructor) {
case ContentFormat: { case ContentFormat: {
@ -302,9 +311,16 @@ const formatText = (transaction, parent, currPos, length, attributes) => {
if (equalAttrs(attr, value)) { if (equalAttrs(attr, value)) {
negatedAttributes.delete(key) negatedAttributes.delete(key)
} else { } else {
if (length === 0) {
// no need to further extend negatedAttributes
// eslint-disable-next-line no-labels
break iterationLoop
}
negatedAttributes.set(key, value) negatedAttributes.set(key, value)
} }
currPos.right.delete(transaction) currPos.right.delete(transaction)
} else {
currPos.currentAttributes.set(key, value)
} }
break break
} }